Page MenuHomePureOS Tracker
Create Task
Maniphest T453

Package out-of-tree driver for BYD touchpad
Open, WishlistPublic
Actions

Description

There is an out-of-tree driver for the BYD touchpad found in Librem 13v1 and Librem 15v2 devices: https://github.com/jayk/psmouse-bydfull-dkms/

Currently it cannot be compiled for latest kernel.

Suggestion is to update and package this, so that users who have the above mentioned hardware can install it easily.

From the author:

This module provides a significantly enhanced touchpad experience. Tapping is disabled, and two-finger scrolling both vertically and horizontally is enabled by default. The right-click zone is also limited to the bottom-right corner of the pad, rather than the right half of the lower quarter of the pad.

Related Objects

Event Timeline

mladen created this task.May 28 2018, 01:50
mladen created this object with edit policy "Restricted Project (Project)".
jonas.smedegaard added a subscriber: jonas.smedegaard.Jun 2 2018, 02:21

Please elaborate on the reason this driver is needed.

I.e. what are the benefits over following https://tracker.pureos.net/w/troubleshooting/byd_driver_not_loaded/ ?

jonas.smedegaard added a comment.Jun 2 2018, 02:26

This seems a duplicate of T52 - and related to T150.

jonas.smedegaard added a comment.EditedJun 2 2018, 02:31

Background info (thanks to Allison Randal): https://patchwork.kernel.org/patch/9424421/

mladen added a comment.Jun 2 2018, 02:43

Please elaborate on the reason this driver is needed.

Author of the driver explained:

This module provides a significantly enhanced touchpad experience. Tapping is disabled, and two-finger scrolling both vertically and horizontally is enabled by default. The right-click zone is also limited to the bottom-right corner of the pad, rather than the right half of the lower quarter of the pad.

Some PureOS users who own devices with BYD touchpad would like to have this driver somehow included. I realize there is huge workload to maintain out-of-tree driver, but in the future we might have adequate manpower for this.

jonas.smedegaard added a comment.Jun 2 2018, 02:53

It seems the proposed out-of-tree driver has bells-and-whistles - i.e. enables multi-touch support and more.

This seems to explain why multi-touch was _not_ enabled in the driver included in Linux: https://lkml.org/lkml/2016/2/2/1071

jonas.smedegaard added a comment.Jun 2 2018, 02:57

@mladen.pejakovic Do I understand you correctly that packaging this driver is an improvement (for some of our users) over the byd driver provided with mainline Linux - but that mainline linux driver for BYD is not broken?

I ask because the subject of this bug talks about issue being a need to "fix" something.

mladen added a comment.Jun 2 2018, 03:00

@jonas.smedegaard Yes. I will remove „fix“ from the title as it is confusing indeed. It supposed to mean that this out-of-tree driver needs to be rebased (is this the right term?) to the latest kernel, as it haven't been updated for a while.

mladen renamed this task from Fix and package out-of-tree driver for BYD touchpad to Package out-of-tree driver for BYD touchpad.Jun 2 2018, 03:00
mladen updated the task description. (Show Details)
jonas.smedegaard added a comment.Jun 2 2018, 03:10

Thanks for the clarifications - makes good sense to me now.

Yes, one way (git lingo, specifically) to express adapting upstream source which has fallen behind and needd patching to match current surrounding source code, is "rebasing".