Page MenuHomePureOS Tracker

hexchat hardcodes firefox
Open, LowPublic

Description

Reference: https://bugs.debian.org/874572

hexchat hard-codes the firefox command in some menus, we could change this to PureBrowser. And we could also set FreeNode #purism channel as default.

We could use these comands before building:

sed -i '\|NAME Open Link| s|Firefox|PureBrowser|' src/common/hexchat.c
sed -i '\|NAME Open Link| s|firefox -new-window %s\\n\\n";|purebrowser -new-window %s\\n\\n"\\\n		"NAME Open Link in a new PureBrowser Window\\n"		"CMD !purebrowser -new-window %s\\n\\n";|' src/common/hexchat.c

The patch for setting default IRC channel (adapted from Ubuntu's/Debian's patch):

--- a/src/common/servlist.c
+++ b/src/common/servlist.c
@@ -165,6 +165,9 @@
 	/* irc. points to chat. but many users and urls still reference it */
 	{0,				"irc.freenode.net"},
 
+	{"Purism (freenode)", 0, 0, 0, LOGIN_SASL, 0, TRUE},
+	{0,				"chat.freenode.net"},
+
 	{"Furnet", 0, 0, 0, 0, 0, TRUE},
 	{0,			"irc.furnet.org"},
 
@@ -928,7 +931,7 @@
 {
 	int i = 0, j = 0;
 	ircnet *net = NULL;
-	guint def_hash = g_str_hash ("freenode");
+	guint def_hash = g_str_hash ("Purism (freenode)");
 
 	while (1)
 	{
--- a/src/fe-gtk/joind.c
+++ b/src/fe-gtk/joind.c
@@ -246,9 +246,9 @@
 							G_CALLBACK (joind_ok_cb), serv);
 							
 	if (serv->network)
-		if (g_ascii_strcasecmp(((ircnet*)serv->network)->name, "freenode") == 0)
+		if (g_ascii_strcasecmp(((ircnet*)serv->network)->name, "Purism (freenode)") == 0)
 		{
-			gtk_entry_set_text (GTK_ENTRY (entry1), "#hexchat");
+			gtk_entry_set_text (GTK_ENTRY (entry1), "#purism");
 		}
 
 	gtk_widget_grab_focus (okbutton1);

Event Timeline

mladen renamed this task from hehchat hardcodes firefox to hexchat hardcodes firefox.May 20 2017, 11:07
mladen created this task.
jonas.smedegaard added a subscriber: jonas.smedegaard.

Better to be browser-agnostic by use of xdg-open

jonas.smedegaard triaged this task as Low priority.Sep 7 2017, 06:27

oh well - it _is_ browser agnostic already (se Debian bugreport).

This bug is about secondary option, so only polish.

Considering that we phased out Purebrowser in Favor of Epiphany and Firefox-ESR and that the bug was closed in Debian.

Do we need to have this open?

@joao.azevedo this issue is hexchat hardcoding a specific web browser - and therefore not specific to PureBrowser (that's just how it was noticed).

So no, I think this issue is valid regardless of status of PureBrowser.