Page MenuHomePureOS Tracker

Update systemd pipe key fix to include Librem 13v4
Closed, ResolvedPublic

Description

The new Librem 13v4 has the same keyboard programming as prior models and as such it suffers from the same pipe key mapping issue. We need to update the same systemd file as in T431 to reference the Librem 13v4 as well:

# Purism Librem 13 V4
evdev:atkbd:dmi:bvn*:bvr*:bd*:svnPurism*:pn*Librem13v4*:pvr*
 KEYBOARD_KEY_56=43

Event Timeline

@kyle.rankin Thanks for filing this. Should this also go upstream?

(Note that I do not have a Librem 13v4 to validate this on an actual hardware device.)

Yes, this should go upstream like with the parent issue. I have tested this fix against my Librem 13 v4.

@kyle.rankin,

the value on the right side is supposed to be a key name. Shouldn't this be something like KEYBOARD_KEY_56=backslash instead

Can you quickly confirm what the RHS of this should be? :) (as, no v4 hardware here to test!)

This is the value I used and tested, and it's the value that we used for the other entries that were already in the file. If we were to change it for this case, we should also change it for the other, previous Librem 13 entries.

it's the value that we used for the other entries that were already in the file

Are you sure?

(ie. upstream want to put something like backslash in there, not a random number.)

My apologies, I have no idea where I got that number. I reviewed my own hand-edited file and it says "backslash"

chris.lamb closed this task as Resolved.Jan 23 2019, 02:45

Merged upstream and fixed locally in:

systemd (239-7pureos2) green; urgency=medium

  * Add support for Purism Librem 13v4 keyboards. This patch was applied
    upstream at <https://github.com/systemd/systemd/pull/11516>.
    (Closes: PureOS:T683)
  * Apply patches from upstream to:
    - Fix FTBFS with a new version of Meson.
    - Prevent FTBFS on new versions of glibc.
  * debian/control: Set headers for PureOS upload.

 -- Chris Lamb <chris.lamb@puri.sm>  Wed, 23 Jan 2019 10:25:47 +0000

Also included in

systemd (240-5pureos1) green; urgency=medium
.
  [ Matthias Klumpp ]
  * Merge with Debian unstable/master, remaining change:
    - Add functionality to configure & run locale-gen when a locale is changed.
  * Update localed locale-gen patches to latest version
  * Modify locale-gen-helper to work with current localed patches
.
  [ Chris Lamb ]
  * Add hwdb-librem13v4-keyboards.patch (PB: #683)
    - Add support for Purism Librem 13v4 keyboards. This patch was applied
      upstream at <https://github.com/systemd/systemd/pull/11516>.
.
  [ Felipe Sateler ]
  * Reenable pristine-tar in gbp.conf.
    The pristine-tar bug has been fixed, so we can use it again.
    This reverts commit 9fcfbbf6fea15eacfa3fad74240431c5f2c3300e.
  * d/watch: add version mangle to transform -rc to ~rc.
    Upstream has started releasing rcs, so let's account for that
.
  [ Dimitri John Ledkov ]
  * debian/tests/storage: improve cleanups.
    On fast ppc64el machines, cryptsetup start job may not complete by the time
    tearDown is executed. In that case stop, causes to simply cancel the start
    job without actually cleaning up the dmsetup node. This leads to failing
    subsequent test as it no longer starts with a clean device. Thus ensure the
    systemd-cryptsetup unit is started, before stopping it.
    Also rmmod scsi_debug module at the end, to allow re-running the test in a
    loop.
  * debian/tests/upstream: Mark TEST-13-NSPAWN-SMOKE as flakey.