Add Librems to flashrom's whitelist
Open, Needs TriagePublic

Description

This should allow flashrom to run on the librems without the need for the 'laptop=force_I_want_a_brick' option.

kakaroto created this task.Aug 31 2017, 6:39 PM
habs added a subscriber: habs.Nov 16 2017, 8:49 AM

I submitted a patch for the Librem 15 here: https://mail.coreboot.org/pipermail/flashrom/2017-November/015218.html

The only nontrivial part was finding the first eight numbers to add in the board_matches[] array in board_enable.c. To find those (0x8086, 0x9d48, 0x8086, 0x9d48, 0x8086, 0x1904, 0x8086, 0x2015 for the L15) I first used lspci -nn to find the ISA bridge and Host bridge in that order, then cross-referenced those LSPCI IDs in my hwinfo output looking for the lines that said e.g. "bus 00, slot 1f, func 0, vend:dev:s_vend:s_dev:rev XXXX:XXXX:YYYY:YYYY:21", where XXXX:XXXX was the ID I saw in my lspci output and YYYY:YYYY were the next two numbers in the sequence. Do this for both the ISA bridge and the host bridge to get the eight numbers.

If someone wants to do the same for the L13 I think that should work too.

wow, thanks a lot @habs ! I am really happy to see this!

Thanks a lot @habs for the contribution. I never did that because I also couldn't figure out proper docs on what those 4 PCI IDS should be., but it feels to me like it can be any PCI device on the machine, I just didn't think that they would uniquely identify the librems. I'm now realizing that uniquely identifying via PCI is not needed, but it rather needs to identify with PCI + dmi information, so it's fine as is.
I tested your patch but unfortunately it didn't work, because the ISA bridge doesn't have a subsystem id, so the pci id that worked for me is : {0x8086, 0x9d48, 0, 0, 0x8086, 0x1904, 0x8086, 0x2015}
Did you send the patch to them via gerrit or do you want me to finish it (add the info for librem 13, and for the previous revisions?) then send it in one commit ?

Thanks again for initiating this task!

habs added a comment.Nov 24 2017, 8:06 PM

Hey @kakaroto -- this has been on my todo list, but if you can do it first (plus if you can do it for the L13, which I don't have information on) then please go ahead. My patch works with my L15 but I don't have more than one model to test it on.

habs added a comment.Nov 24 2017, 8:07 PM

Also, I only submitted the patch via that email. I haven't committed it to any repos yet. You're free to take my code and run with it to finish this -- thank you!

Add Comment