hydrogen - promotes non-free code via runtime addons download feature
Closed, ResolvedPublic


Reference: https://labs.parabola.nu/issues/288 https://bugs.debian.org/869180

Package hydrogen supports downloading addons at runtime, and default feed contains nonfree addons.

From Parabola:

# Change to list with free licensed drumkits only
 sed -i -e 's|www[.]hydrogen-music[.]org/feeds/drumkit_list[.]php|repo.parabola.nu/other/hydrogen-libre/feeds/drumkit_list.php|'\
 $(grep -rlI 'www[.]hydrogen-music[.]org/feeds/drumkit_list[.]php')
mladen created this task.May 30 2017, 1:35 PM
jonas.smedegaard added a subscriber: hema.prathaban.
jonas.smedegaard removed a subscriber: hema.prathaban.

The list curated by Parabola seems to permit non-commercial CC licenses and does therefore not comply with Debian Free Software Guidelines.

I will try setup a website on a debian.net domain, hosting a list as a static file but generated with a script maintainined in the Debian multimedia team to filter upstream list as we in Debian consider suitable.

turns out the package hydrogen-drumkits contain roughly the free parts of what is offered online, so setting up a curated live list is really no gain.

...which also means that I cannot defend changing the URL in Debian, as from the POV of Debian such change is silly at best.

I will therefore make a fork of Hydrogen for PureOS with this sole patch.

mladen added a comment.EditedJul 18 2017, 10:03 PM

I'll examine manually all drumkits offered in Debian package the online repo. If there really are some not allowed by FSF, can we simply patch the package?

mladen added a comment.EditedJul 18 2017, 10:30 PM

This is the list which contains only free drumkits: https://tracker.pureos.net/P2
I have removed drumkits clearly labeled as non-free as well as others without license.

It differs from the one provided by Parabola, I am not sure why simply because they did not update it for a long time: https://repomirror.parabola.nu/other/hydrogen-libre/feeds/.

I worry about bitrot for PureOS too.

Instead of editing by hand, could you please instead describe your criteria, so that I can make a script that can be put into a cron job, polling upstream XML periodically and generate our derived XML using e.g. a whitelist of licenses we consider ok.

Can this help: drumkit_list-free.diff ?

Basically, any drumkit with empty or Do not redistribute or publish the inluded samples licence tag should be removed. There's one exception with licence tag empty but the description states it is under GPL.

The diff I had already done, but your description on *why* you changed as you did is quite helpful.

Based on that, I am now inspecting closely the drumkits distributed in Debian (which I guess is in PureOS too) that you have excluded in your list: Either those are wrong to ship in debian, or the metadata is incomplete and the drumkits are in fact free.

So far I have found that 2 drumkits are free but the metadata is sloppy, and one drumkit I have not found licensing for (which means if noone else does either then that drumkit has to go from Debian).

Hydrogen-compatible XML feed with only DFSG-free drumkits are now established at http://freepats.zenvoid.org/hydrogen.xml

Fix released to Debian as version 0.9.7-3: https://tracker.debian.org/news/863564

So feel free to close this one here as it will come in from Debian soon :)

mak lowered the priority of this task from "95" to "Freedom Issue".Aug 19 2017, 5:08 AM
jonas.smedegaard closed this task as "Resolved".Aug 22 2017, 7:58 AM

Fixed hydrogen entered testing today.

jonas.smedegaard changed the title from "[FREEDOM ISSUE] hydrogen" to "hydrogen-drumkits - contain nonfree code".Nov 2 2017, 4:44 AM
jonas.smedegaard edited the task description. (Show Details)
jonas.smedegaard changed the title from "hydrogen-drumkits - contain nonfree code" to "hydrogen - promotes non-free code via runtime addons download feature".Nov 2 2017, 4:51 AM
jonas.smedegaard edited the task description. (Show Details)

Add Comment